Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): use correct $config for finding basePath #9706

Merged
merged 1 commit into from Aug 24, 2021

Conversation

danielroe
Copy link
Member

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

runtimeConfig within ssrContext is still divided into public and private.

Context: issue introduced in #8520
Resolves #9625

Checklist:

  • All new and existing tests are passing.

@danielroe danielroe self-assigned this Aug 23, 2021
@danielroe danielroe requested a review from pi0 August 23, 2021 07:45
@pi0 pi0 merged commit 3c10f17 into dev Aug 24, 2021
@pi0 pi0 deleted the fix/9625-create-next-basepath branch August 24, 2021 08:54
@pi0 pi0 mentioned this pull request Jun 23, 2022
@Herbata-Sys
Copy link

@danielroe Hi, maybe you know why this is still not fixed in newest nuxt2 - v2.15.8 even though it was merged long time ago. I can't find your fix in v2.15.8 code.

Copy link
Member Author

You're right. This will be present in 2.16 which should be coming soon.

@Herbata-Sys
Copy link

Good to hear this

@danielroe danielroe added the 2.x label Jan 18, 2023
@danielroe danielroe mentioned this pull request Jan 19, 2023
@danielroe danielroe mentioned this pull request Jan 20, 2023
@danielroe danielroe mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants