Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add prefetchPayloads to router options #9715

Merged
merged 1 commit into from Aug 27, 2021
Merged

Conversation

kedrzu
Copy link

@kedrzu kedrzu commented Aug 27, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Missing prop that is documented here : https://nuxtjs.org/docs/2.x/configuration-glossary/configuration-router#prefetchpayloads

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2021

Codecov Report

Merging #9715 (6948c82) into dev (b014777) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #9715   +/-   ##
=======================================
  Coverage   65.17%   65.17%           
=======================================
  Files          94       94           
  Lines        4109     4109           
  Branches     1127     1127           
=======================================
  Hits         2678     2678           
  Misses       1152     1152           
  Partials      279      279           
Flag Coverage Δ
unittests 65.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b014777...6948c82. Read the comment docs.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❤️

@danielroe danielroe changed the title types: add prefetchPayloads to router options fix(types): add prefetchPayloads to router options Aug 27, 2021
@clarkdo clarkdo merged commit 2ef0537 into nuxt:dev Aug 27, 2021
@kedrzu kedrzu deleted the patch-1 branch August 27, 2021 09:51
@pi0 pi0 mentioned this pull request Jun 23, 2022
@danielroe danielroe added the 2.x label Jan 18, 2023
@danielroe danielroe mentioned this pull request Jan 19, 2023
@danielroe danielroe mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants