Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): add basic types for Nuxt interface #9772

Merged
merged 5 commits into from Feb 14, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 7, 2021

Types of changes

  • Bug fix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

While we are migrating soon to @nuxt/kit that has fully typed Nuxt interface with nuxt2 backward compatibility, it would probably worth to fix a long time missing interface for Nuxt

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0 pi0 mentioned this pull request Sep 7, 2021
2 tasks
@pi0
Copy link
Member Author

pi0 commented Sep 7, 2021

We can probably bring some more hints from https://github.com/nuxt/test-utils/blob/main/src/context.ts#L30

@pi0 pi0 marked this pull request as ready for review June 23, 2022 23:35
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022

Codecov Report

Base: 66.25% // Head: 66.25% // No change to project coverage 👍

Coverage data is based on head (fb2310e) compared to base (d48efa6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #9772   +/-   ##
=======================================
  Coverage   66.25%   66.25%           
=======================================
  Files          93       93           
  Lines        4090     4090           
  Branches     1156     1156           
=======================================
  Hits         2710     2710           
  Misses       1115     1115           
  Partials      265      265           
Flag Coverage Δ
unittests 66.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danielroe danielroe merged commit c493723 into 2.x Feb 14, 2023
@danielroe danielroe deleted the feat/nuxt-type branch February 14, 2023 11:59
@danielroe danielroe mentioned this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants