Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): nuxt-child-key in web-types.json #9792

Merged
merged 1 commit into from Sep 17, 2021

Conversation

jon-ht
Copy link

@jon-ht jon-ht commented Sep 13, 2021

This is just a typo in a property of Nuxt component

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

PhpStorm is able to provide autocompletion thanks to web-types.json file. There is one property with a typo

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-commenter
Copy link

Codecov Report

Merging #9792 (3694d2e) into dev (3e9d7e3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #9792   +/-   ##
=======================================
  Coverage   65.15%   65.15%           
=======================================
  Files          94       94           
  Lines        4110     4110           
  Branches     1127     1127           
=======================================
  Hits         2678     2678           
  Misses       1153     1153           
  Partials      279      279           
Flag Coverage Δ
unittests 65.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e9d7e3...3694d2e. Read the comment docs.

@clarkdo clarkdo changed the title fix: nuxt-child-key in web-types.json fix(vue-app): nuxt-child-key in web-types.json Sep 17, 2021
@clarkdo clarkdo merged commit dc64e4e into nuxt:dev Sep 17, 2021
@jon-ht jon-ht deleted the fix/web-types-schema branch September 17, 2021 14:59
@pi0 pi0 mentioned this pull request Jun 23, 2022
@danielroe danielroe added the 2.x label Jan 18, 2023
@danielroe danielroe mentioned this pull request Jan 19, 2023
@danielroe danielroe mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants