Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): fix external redirect link #9816

Merged
merged 2 commits into from Sep 17, 2021
Merged

chore(test): fix external redirect link #9816

merged 2 commits into from Sep 17, 2021

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Sep 17, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Fix current failing test by correcting the doc link.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pi0
Copy link
Member

pi0 commented Sep 17, 2021

We are adding back /2.x (or probaby /v2) it was a quick fix for docus issue. I guess we can find a more permanent redirect not breaking e2e test in the future...

@clarkdo
Copy link
Member Author

clarkdo commented Sep 17, 2021

@pi0 Should we merge this or wait fix from doc side ?

@pi0
Copy link
Member

pi0 commented Sep 17, 2021

Let's use example.com? :D They seem to preserve both trailing slash cases

@clarkdo
Copy link
Member Author

clarkdo commented Sep 17, 2021

Looks good

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2021

Codecov Report

Merging #9816 (607227e) into dev (dc64e4e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #9816   +/-   ##
=======================================
  Coverage   65.15%   65.15%           
=======================================
  Files          94       94           
  Lines        4110     4110           
  Branches     1127     1127           
=======================================
  Hits         2678     2678           
  Misses       1153     1153           
  Partials      279      279           
Flag Coverage Δ
unittests 65.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc64e4e...607227e. Read the comment docs.

@clarkdo clarkdo merged commit 816007b into dev Sep 17, 2021
@clarkdo clarkdo deleted the fix/test-link branch September 17, 2021 15:51
@pi0 pi0 mentioned this pull request Jun 23, 2022
@danielroe danielroe added the 2.x label Jan 18, 2023
@danielroe danielroe mentioned this pull request Jan 19, 2023
@danielroe danielroe mentioned this pull request Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants