Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add return type for error() #19044

Merged
merged 2 commits into from Mar 2, 2023
Merged

fix(types): add return type for error() #19044

merged 2 commits into from Mar 2, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #10507

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds a return type for the error() method.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Feb 15, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0b1a4d3) 66.18% compared to head (c8b508a) 66.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x   #19044   +/-   ##
=======================================
  Coverage   66.18%   66.18%           
=======================================
  Files          93       93           
  Lines        4096     4096           
  Branches     1158     1158           
=======================================
  Hits         2711     2711           
  Misses       1119     1119           
  Partials      266      266           
Flag Coverage Ξ”
unittests 66.18% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

@danielroe danielroe merged commit d1b95c3 into 2.x Mar 2, 2023
@danielroe danielroe deleted the fix/error-return branch March 2, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants