Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): add node-fetch-native to externals list #19755

Merged
merged 1 commit into from Mar 17, 2023

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #10751

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds node-fetch-native to the externals list when building. It also marks cjs and mjs as allowable native file extensions to allow avoiding bundling these files.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Mar 16, 2023

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (093e1b1) 65.96% compared to head (a7ca27a) 65.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x   #19755   +/-   ##
=======================================
  Coverage   65.96%   65.96%           
=======================================
  Files          93       93           
  Lines        4113     4113           
  Branches     1165     1165           
=======================================
  Hits         2713     2713           
  Misses       1133     1133           
  Partials      267      267           
Flag Coverage Ξ”
unittests 65.96% <0.00%> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
packages/webpack/src/config/server.js 2.27% <0.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report in Codecov by Sentry.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if already tested

@danielroe danielroe merged commit 4bc3738 into 2.x Mar 17, 2023
13 checks passed
@danielroe danielroe deleted the fix/node-fetch-native branch March 17, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants