fix(utils): respect patterns within paths when sorting routes #20669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
# Conflicts: # packages/utils/test/__snapshots__/route.test.js.snap # yarn.lock
danielroe
reviewed
May 5, 2023
Make the / optional and match : or * anywhere in the string. This ensures that special routes will be below normal routes. Also ensures that route / will be sorted before the special routes.
|
@danielroe can we run the actions on this PR ? |
|
@danielroe we got an error on the windows audit, how can we fix that ? It's a timeout error. |
rchl
reviewed
May 16, 2023
β¦change the priority of param route
marcelobotega
force-pushed
the
bugfix/sorte-route-fix
branch
from
fb07d51
to
bce4af8
Compare
rchl
previously approved these changes
May 17, 2023
There was a problem hiding this comment.
I've tested this on a couple of projects that (admittedly) only have a single * route but I haven't noticed any issues.
One thing that happens consistently is that the root route (/) changes position to after all other dynamic routes (ones that use :). So in theory that could result in slightly slower resolving of that particular route but not sure if it's something to be concerned about.
So thumbs up from me.
rchl
reviewed
May 17, 2023
Co-authored-by: RafaΕ ChΕodnicki <rchl2k@gmail.com>
rchl
previously approved these changes
May 17, 2023
danielroe
reviewed
May 19, 2023
rchl
approved these changes
May 22, 2023
danielroe
approved these changes
May 22, 2023
danielroe
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Fixes #10630
β Type of change
π Description
Update sortRoutes to handle routes with letters and * (test*)
Resolves #10630
π Checklist