Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel-preset-app): add explicit dep on used babel plugin #21488

Merged
merged 1 commit into from Jun 9, 2023

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Jun 9, 2023

πŸ”— Linked issue

babel/babel-plugin-proposal-private-property-in-object#1 (comment)
resolves #21489
resolves nuxt/create-nuxt-app#1030

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This adds an explicit dependency on the version of @babel/plugin-proposal-private-property-in-object we need in the project.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe changed the title fix(babel-preset-app): add explicit dep on used plugin fix(babel-preset-app): add explicit dep on used babel plugin Jun 9, 2023
@danielroe danielroe merged commit a0fd395 into 2.x Jun 9, 2023
16 checks passed
@danielroe danielroe deleted the fix/explicit-babel-plugin branch June 9, 2023 11:17
@nicolo-ribaudo
Copy link

@danielroe If it takes too long to release this, I can temporarily add a workaround in Babel. Out of curiosity, did you get similar bug reports ~1 week ago?

In Babel 7.22.0 we removed the @babel/plugin-proposal-private-property-in-object because we didn't need anymore. That broke all create-react-app installs because it has a bug identical to the one fixed in this PR, and since create-react-app is not maintained we temporarily added the dependency back to Babel.

To avoid having the unnecessary dependency, we now replaced it with a placeholder whose unique goal is to fix CRA compatibility, and that otherwise behaves as a missing dependency when required.

I'm surprised that we didn't discover this problem in Nuxt when we released 7.22.0 πŸ€”

@nicolo-ribaudo
Copy link

Oh well :)

@danielroe
Copy link
Member Author

Sorry for the pain @nicolo-ribaudo!

For everyone else, until this is released in 2.17, you can opt in to use nuxt-edge in your projects, or add this plugin explicitly as a dev dependency. (I'll be triggering an edge release shortly.)

We expect to release 2.17 this weekend.

@Eugene313
Copy link

Yes I had same problem 1 week ago

@danielroe danielroe mentioned this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants