-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to hookable
package
#24426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## 2.x #24426 +/- ##
==========================================
+ Coverage 66.20% 66.22% +0.01%
==========================================
Files 93 93
Lines 4119 4121 +2
Branches 1169 1169
==========================================
+ Hits 2727 2729 +2
Misses 1126 1126
Partials 266 266
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. |
danielroe
approved these changes
Nov 23, 2023
pi0
approved these changes
Nov 24, 2023
Merged
Closed
This was referenced May 18, 2024
This was referenced May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Resolves: #24419
β Type of change
π Description
This PR moves Nuxt 2 to the
hable
package successor,hookable
, which allows us to unregister hooks and create developer experience more similar to Nuxt 3 / Bridgeπ Checklist