Netlify Build Failing #12764

fanckush · 2021-11-10T14:35:29Z

Environment

Operating System: Darwin
Node Version: v14.18.1
Nuxt Version: 0.0.0
Package Manager: yarn@1.22.10
Bundler: Webpack
User Config: -
Runtime Modules: -
Build Modules: -

Describe the bug

Am I doing something wrong?

Netlify Deploy is failing

1:48:13 PM:   2. Functions bundling                                         
1:48:13 PM: ────────────────────────────────────────────────────────────────
1:48:13 PM: 
1:48:13 PM: Packaging Functions from .netlify/functions-internal directory:
1:48:13 PM:  - server/server.ts
1:48:13 PM: 
1:48:13 PM:  > .netlify/functions-internal/server/node_modules/node-fetch/src/index.js:9:17: error: Could not resolve "node:http" (mark it as external to exclude it from the bundle)
1:48:13 PM:     9 │ import http from 'node:http';
1:48:13 PM:       ╵                  ~~~~~~~~~~~
1:48:13 PM:  > .netlify/functions-internal/server/node_modules/node-fetch/src/index.js:10:18: error: Could not resolve "node:https" (mark it as external to exclude it from the bundle)
1:48:13 PM:     10 │ import https from 'node:https';
1:48:13 PM:        ╵                   ~~~~~~~~~~~~
1:48:13 PM:  > .netlify/functions-internal/server/node_modules/node-fetch/src/index.js:11:17: error: Could not resolve "node:zlib" (mark it as external to exclude it from the bundle)
1:48:13 PM:     11 │ import zlib from 'node:zlib';
1:48:13 PM:        ╵                  ~~~~~~~~~~~
1:48:13 PM:  > .netlify/functions-internal/server/node_modules/node-fetch/src/index.js:12:52: error: Could not resolve "node:stream" (mark it as external to exclude it from the bundle)
1:48:13 PM:     12 │ import Stream, {PassThrough, pipeline as pump} from 'node:stream';
1:48:13 PM:        ╵                                                     ~~~~~~~~~~~~~
1:48:13 PM:  > .netlify/functions-internal/server/node_modules/node-fetch/src/body.js:8:34: error: Could not resolve "node:stream" (mark it as external to exclude it from the bundle)
1:48:13 PM:     8 │ import Stream, {PassThrough} from 'node:stream';
1:48:13 PM:       ╵                                   ~~~~~~~~~~~~~
1:48:13 PM:  > .netlify/functions-internal/server/node_modules/node-fetch/src/body.js:9:31: error: Could not resolve "node:util" (mark it as external to exclude it from the bundle)
1:48:13 PM:     9 │ import {types, deprecate} from 'node:util';
1:48:13 PM:       ╵                                ~~~~~~~~~~~
1:48:13 PM:  > .netlify/functions-internal/server/node_modules/node-fetch/src/request.js:10:34: error: Could not resolve "node:url" (mark it as external to exclude it from the bundle)
1:48:13 PM:     10 │ import {format as formatUrl} from 'node:url';
1:48:13 PM:        ╵                                   ~~~~~~~~~~
1:48:13 PM:  > .netlify/functions-internal/server/node_modules/node-fetch/src/headers.js:7:20: error: Could not resolve "node:util" (mark it as external to exclude it from the bundle)
1:48:13 PM:     7 │ import {types} from 'node:util';
1:48:13 PM:       ╵                     ~~~~~~~~~~~
1:48:13 PM:  > .netlify/functions-internal/server/node_modules/node-fetch/src/headers.js:8:17: error: Could not resolve "node:http" (mark it as external to exclude it from the bundle)
1:48:13 PM:     8 │ import http from 'node:http';
1:48:13 PM:       ╵                  ~~~~~~~~~~~
1:48:13 PM:  > .netlify/functions-internal/server/node_modules/fetch-blob/from.js:1:59: error: Could not resolve "node:fs" (mark it as external to exclude it from the bundle)
1:48:13 PM:     1 │ import { statSync, createReadStream, promises as fs } from 'node:fs'
1:48:13 PM:       ╵                                                            ~~~~~~~~~
1:48:13 PM: 10 of 12 errors shown (disable the message limit with --log-limit=0)
1:48:13 PM: 
1:48:13 PM: ────────────────────────────────────────────────────────────────
1:48:13 PM:   Dependencies installation error                               
1:48:13 PM: ────────────────────────────────────────────────────────────────
1:48:13 PM:

Reproduction

Additional context

No response

Logs

No response

The text was updated successfully, but these errors were encountered:

danielroe · 2021-11-10T14:39:37Z

@fanckush See if you can set NODE_VERSION=16 (or 14.13.1+) in the environment variables configuration section.

fanckush · 2021-11-10T14:47:30Z

@danielroe thanks for the quick reply,
I get the same error with both NODE_VERSION=16 as well as NODE_VERSION=14.16.0

the ENV is working as I see the following log:
3:45:10 PM: Now using node v14.16.0 (npm v6.14.11)

but the error is the same in both cases

danielroe · 2021-11-10T14:50:12Z

Then I think this should be raised upstream with Netlify as it's happening not within the Nuxt build step but within packaging functions.

cc: @ascorbic

fanckush · 2021-11-10T15:02:39Z

Thanks! interestingly, in the logs Netlify says:

A Netlify Function failed to require one of its dependencies
Please make sure it is present in the site's top-level "package.json"

this makes it seem like it's on my end to add something

danielroe · 2021-11-10T16:27:37Z

@fanckush My reading of the error message is that the script bundling the functions is expecting node:http (for example) to be a dependency, not realising that it is a node built-in.

ascorbic · 2021-11-10T16:38:35Z

Hey. This certainly seems to be a bundling issue. The node:-prefix import issue came up before, but I thought we had fixed it. Tagging @eduardoboucas to see if he has any insight

hrishikesh-k · 2021-11-10T16:55:09Z

There's a related thread on Netlify Forums: https://answers.netlify.com/t/deploying-a-new-nuxt-3-app-result-to-error/47029

netlify-team-account-1 · 2021-11-11T09:54:09Z

This seems like a regression related to a change I introduced into Netlify's bundling process. Looking into it!

netlify-team-account-1 · 2021-11-11T10:34:02Z

I was able to reproduce & fix this in netlify/zip-it-and-ship-it#802 🥳 Will ping here once it's deployed.

pi0 · 2021-11-11T10:40:41Z

Thanks for fix @netlify-team-account-1 <3

I'm wondering why netlify has to re-bundle nitro functions that are already made for Nelify? It is because you expect a CommonJS entrypoint? /cc @ascorbic

ascorbic · 2021-11-11T10:44:38Z

Correct. AWS lambda doesn't support ESM, so we need to transpile it all. If Nitro can generate a node 14 -compatible cjs bundle then it could run it unchanged

pi0 · 2021-11-11T11:07:22Z

Correct. AWS lambda doesn't support ESM, so we need to transpile it all. If Nitro can generate a node 14 -compatible cjs bundle then it could run it unchanged

I was kinda assuming Netlify does dark magic for supporting ESM with lambda till today 😆 But of course we can update netlify preset to emit CJS (or CJS entry). We need it for generic AWS support anyway.

BTW may I ask how it works? If the function is using .js netlify won't use esbuild or there is a specific configuration to specify not building?

danielroe · 2021-11-11T11:10:46Z

I think it just might be possible to emit the right kind of entrypoint (while keeping the rest of the lambda ESM). There are some examples out there of people who've done the same with AWS Lambda, e.g. here.

productdevbook · 2021-11-11T14:42:13Z

Environment

Operating System: Darwin
Node Version: v16.13.0
Nuxt Version: 3.0.0-27277330.202617b
Package Manager: yarn@1.22.15
Bundler: Vite
User Config: buildModules, build
Runtime Modules: -
Build Modules: @pinia/nuxt@0.1.5

Describe the bug

https://v3nuxt.netlify.app

Reproduction

https://github.com/productdevbook/nuxt3-app

Additional context

No response

Logs

No response

ascorbic · 2021-11-11T15:27:19Z

I was kinda assuming Netlify does dark magic for supporting ESM with lambda till today 😆 But of course we can update netlify preset to emit CJS (or CJS entry). We need it for generic AWS support anyway.
BTW may I ask how it works? If the function is using .js netlify won't use esbuild or there is a specific configuration to specify not building?

@pi0 That does sound like the simplest solution. Changing it to .js should just work: it will switch back to the default bundler, which doesn't compile anything. I made the entrypoint .ts because at the time that was the simplest way to switch the bundler into esbuild mode without needing to add any config (now .mjs will do the same).

ascorbic · 2021-11-11T15:28:37Z

I think it just might be possible to emit the right kind of entrypoint (while keeping the rest of the lambda ESM). There are some examples out there of people who've done the same with AWS Lambda, e.g. here.

@danielroe Would this give any benefit aside from consistency in compiling most targets to ESM?

pi0 · 2021-11-11T16:31:44Z

Would this give any benefit aside from consistency in compiling most targets to ESM?

Yes! Most importantly for dealing with esm-only packages. If we output CJS format should bundle all or some of the externals as well losing benefit of vercel/nft.

florian-lefebvre · 2021-11-11T18:11:54Z

Environment
* Operating System: `Darwin`

* Node Version:     `v16.13.0`

* Nuxt Version:     `3.0.0-27277330.202617b`

* Package Manager:  `yarn@1.22.15`

* Bundler:          `Vite`

* User Config:      `buildModules`, `build`

* Runtime Modules:  `-`

* Build Modules:    `@pinia/nuxt@0.1.5`
Describe the bug

https://v3nuxt.netlify.app
### Reproduction
https://github.com/productdevbook/nuxt3-app

Additional context

No response

Logs

No response

I have the same right now, I'll use Vercel until this issue is resolved.

ascorbic · 2021-11-11T19:09:46Z

@florian-lefebvre Did you just deploy that? The fix should have been live for a while now but it will need to be a new deploy before it will work.

florian-lefebvre · 2021-11-11T19:20:17Z

It still doesn't work. I just deployed it, here is the link https://youthful-gates-3fd198.netlify.app/.

arnauddsj · 2021-11-11T19:38:49Z

I confirm same problem here. Had the same error as the original post and now getting same error as florian-lefebvre on my site https://stoic-fermat-995d10.netlify.app/

Thomasevano · 2021-11-12T00:32:15Z

Hello, same issue here using nuxt 3

netlify-team-account-1 · 2021-11-12T07:20:20Z

Importing Node modules with the node: prefix was introduced in Node v14. The stacktraces seem like they're from Node v12, which is currently the default runtime on Netlify (probably going to be v14 soon). Please upgrade your deployment to v14 by setting the AWS_LAMBDA_JS_RUNTIME environment variable to nodejs14.x. This should resolve the error you're seeing.

fanckush · 2021-11-12T09:00:47Z

So after the fix from @netlify-team-account-1 the deploy was succeeding! 🎉
But in the browser I was getting a runtime error like the others:

{"errorType":"Runtime.ImportModuleError","errorMessage":"Error: Cannot find module 'node:http'\nRequire stack:\n- /var/task/.netlify/functions-internal/server/server.js\n- /var/task/server.js\n- /var/runtime/UserFunction.js\n- /var/runtime/index.js","trace":["Runtime.ImportModuleError: Error: Cannot find module 'node:http'","Require stack:","- /var/task/.netlify/functions-internal/server/server.js","- /var/task/server.js","- /var/runtime/UserFunction.js","- /var/runtime/index.js","    at _loadUserApp (/var/runtime/UserFunction.js:100:13)","    at Object.module.exports.load (/var/runtime/UserFunction.js:140:17)","    at Object.<anonymous> (/var/runtime/index.js:43:30)","    at Module._compile (internal/modules/cjs/loader.js:999:30)","    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)","    at Module.load (internal/modules/cjs/loader.js:863:32)","    at Function.Module._load (internal/modules/cjs/loader.js:708:14)","    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)","    at internal/main/run_main_module.js:17:47"]}

Setting the following AWS ENV did not solve the issue (still getting the same runtime error):

EDIT: I've rebuild but forgot to mention in the original message

netlify-team-account-1 · 2021-11-12T09:05:32Z

Updated env vars only go into effect on new deploys, did you redeploy your site?

leon0399 · 2021-11-12T10:14:54Z

@netlify-team-account-1 just tried to re-deploy my site with these envs, still same error

{
  "errorType": "Runtime.ImportModuleError",
  "errorMessage": "Error: Cannot find module 'node:http'\nRequire stack:\n- /var/task/.netlify/functions-internal/server/server.js\n- /var/task/server.js\n- /var/runtime/UserFunction.js\n- /var/runtime/index.js",
  "trace": [
    "Runtime.ImportModuleError: Error: Cannot find module 'node:http'",
    "Require stack:",
    "- /var/task/.netlify/functions-internal/server/server.js",
    "- /var/task/server.js",
    "- /var/runtime/UserFunction.js",
    "- /var/runtime/index.js",
    "    at _loadUserApp (/var/runtime/UserFunction.js:100:13)",
    "    at Object.module.exports.load (/var/runtime/UserFunction.js:140:17)",
    "    at Object.<anonymous> (/var/runtime/index.js:43:30)",
    "    at Module._compile (internal/modules/cjs/loader.js:1072:14)",
    "    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1101:10)",
    "    at Module.load (internal/modules/cjs/loader.js:937:32)",
    "    at Function.Module._load (internal/modules/cjs/loader.js:778:12)",
    "    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)",
    "    at internal/main/run_main_module.js:17:47"
  ]
}

ascorbic · 2021-11-12T10:46:52Z

Thanks. That is very strange. We'll be looking into it today.

ascorbic · 2021-11-12T11:58:15Z

It seems the frustrating answer is that the AWS Lambda runtime is currently on Node v14.17.4, while node: prefix support was introduced in Node 14.18! We're trying to think of a solution that's not "don't use node: prefixes"

ascorbic · 2021-11-12T12:01:22Z

It's node-fetch that's the problem: they claim to support Node 12, but in the latest release changed all the imports to use the prefix. I'm going to open an issue.

ascorbic · 2021-11-12T12:13:30Z

OK, there already is an issue covering it: node-fetch/node-fetch#1367
We're looking into implementing the esbuild plugin solution. Thanks everyone for your patience!

ascorbic · 2021-11-12T12:33:14Z

I think it just might be possible to emit the right kind of entrypoint (while keeping the rest of the lambda ESM). There are some examples out there of people who've done the same with AWS Lambda, e.g. here.

Separately, @danielroe: I've confirmed that this should work for us too, and would mean it woudln't be re-bundled.

ascorbic · 2021-11-12T12:49:05Z

And, of course, should work for the regular lambda preset too

netlify-team-account-1 · 2021-11-12T15:44:18Z

I deployed netlify/zip-it-and-ship-it#806 to production. The issue should not occur anymore. If it does, please let me know :)

productdevbook · 2021-11-12T16:15:37Z

I deployed netlify/zip-it-and-ship-it#806 to production. The issue should not occur anymore. If it does, please let me know :)

fixed thank you

florian-lefebvre · 2021-11-12T18:01:07Z

Fixed !

fanckush · 2021-11-12T22:32:05Z

Works great!! The Manual ENV vars are not needed either! I was able to get it working out-of-the-box
I'll close the issue

fanckush added bug nuxt3 labels Nov 10, 2021

danielroe added upstream and removed nuxt3 labels Nov 10, 2021

netlify-team-account-1 mentioned this issue Nov 11, 2021

fix: esm imports with node: prefix on esbuild netlify/zip-it-and-ship-it#802

Merged

netlify-team-account-1 mentioned this issue Nov 12, 2021

fix: compile away node:-namespaced imports netlify/zip-it-and-ship-it#806

Merged

fanckush closed this as completed Nov 12, 2021

danielroe mentioned this issue Jan 19, 2023

emit cjs wrapper for lambda + netlify nitro presets #12850

Closed

danielroe added the 3.x label Jan 19, 2023

J-Kern mentioned this issue Nov 11, 2021

Runtime.ImportModuleError - netlify deploy #12765

Closed

danielroe transferred this issue from nuxt/framework Jan 19, 2023

Netlify Build Failing #12764

Netlify Build Failing #12764

Comments

fanckush commented Nov 10, 2021 • edited

Environment

Describe the bug

Reproduction

Additional context

Logs

danielroe commented Nov 10, 2021

fanckush commented Nov 10, 2021 • edited

danielroe commented Nov 10, 2021

fanckush commented Nov 10, 2021

danielroe commented Nov 10, 2021

ascorbic commented Nov 10, 2021 • edited

hrishikesh-k commented Nov 10, 2021

netlify-team-account-1 commented Nov 11, 2021

netlify-team-account-1 commented Nov 11, 2021 • edited

pi0 commented Nov 11, 2021 • edited

ascorbic commented Nov 11, 2021

pi0 commented Nov 11, 2021 • edited

danielroe commented Nov 11, 2021 • edited

productdevbook commented Nov 11, 2021

Environment

Describe the bug

Reproduction

Additional context

Logs

ascorbic commented Nov 11, 2021 • edited

ascorbic commented Nov 11, 2021

pi0 commented Nov 11, 2021 • edited

florian-lefebvre commented Nov 11, 2021

Environment

Describe the bug

Additional context

Logs

ascorbic commented Nov 11, 2021

florian-lefebvre commented Nov 11, 2021

arnauddsj commented Nov 11, 2021

Thomasevano commented Nov 12, 2021 • edited

netlify-team-account-1 commented Nov 12, 2021

fanckush commented Nov 12, 2021 • edited

netlify-team-account-1 commented Nov 12, 2021

leon0399 commented Nov 12, 2021

ascorbic commented Nov 12, 2021

ascorbic commented Nov 12, 2021

ascorbic commented Nov 12, 2021

ascorbic commented Nov 12, 2021 • edited

ascorbic commented Nov 12, 2021

ascorbic commented Nov 12, 2021

netlify-team-account-1 commented Nov 12, 2021

productdevbook commented Nov 12, 2021

florian-lefebvre commented Nov 12, 2021

fanckush commented Nov 12, 2021

fanckush commented Nov 10, 2021 •

edited

fanckush commented Nov 10, 2021 •

edited

ascorbic commented Nov 10, 2021 •

edited

netlify-team-account-1 commented Nov 11, 2021 •

edited

pi0 commented Nov 11, 2021 •

edited

pi0 commented Nov 11, 2021 •

edited

danielroe commented Nov 11, 2021 •

edited

ascorbic commented Nov 11, 2021 •

edited

pi0 commented Nov 11, 2021 •

edited

Thomasevano commented Nov 12, 2021 •

edited

fanckush commented Nov 12, 2021 •

edited

ascorbic commented Nov 12, 2021 •

edited