New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External redirection improvements #14704

Closed

3 tasks done

pi0 opened this issue Aug 24, 2022 · 1 comment

Labels

3.x enhancement

Member

pi0 commented Aug 24, 2022 •

edited

It is possible (currently in edge) now to use navigateTo for external URL redirections

Base PR feat(nuxt): navigateTo supports external redirects framework#5022 by @manniL
Avoid async logic going on during redirection (feat(nuxt): navigateTo supports external redirects framework#5022 (comment))
Document navigateTo(URL, { external: true }) (docs: document external option of navigateTo framework#7188)

The text was updated successfully, but these errors were encountered:

pi0 added the enhancement label

pi0 mentioned this issue

feat(nuxt): navigateTo supports external redirects nuxt/framework#5022

Merged

7 tasks

DamianGlowala mentioned this issue

docs: document external option of navigateTo nuxt/framework#7188

Merged

7 tasks

Member

danielroe commented Nov 9, 2022

One last thing to ensure: In nuxt 2, we had this problem with external navigations that during navigation, rest of logic goes on. And solution was a custom made error because it was sync. I think we could do something like a never resolving promise that avoids this. (will make a reproduction and implement in later PR btw need more testing)

@pi0 Would you explain a bit more about this? Does nuxt/framework#8821 resolve it?

pi0 closed this as completed

danielroe added the 3.x label

danielroe transferred this issue from nuxt/framework

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment