Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Head components are always bundled #15151

Closed
harlan-zw opened this issue Oct 13, 2022 · 4 comments
Closed

Head components are always bundled #15151

harlan-zw opened this issue Oct 13, 2022 · 4 comments
Assignees
@danielroe
Labels
3.x bug performance

Comments

@harlan-zw
Copy link
Contributor

harlan-zw commented Oct 13, 2022 •
edited

Environment

  • Operating System: Linux
  • Node Version: v16.16.0
  • Nuxt Version: 3.0.0-rc.11
  • Nitro Version: 0.5.4
  • Package Manager: yarn@3.2.4
  • Builder: vite
  • User Config: -
  • Runtime Modules: -
  • Build Modules: -

Reproduction

Latest nuxt: npx nuxi info

Describe the bug

Even when the head components aren't used, they are bundled with your app.

image

The cost of including them like this is pretty minimal 910 B (gzip), it accounts for 1.9% of the total bundle. Still not worth including code that may not be needed.

Additional context

No response

Logs

No response
@danielroe Volta.net
Copy link
Member

Have you checked the bundle to see what specifically is included?

@danielroe danielroe self-assigned this Oct 13, 2022
@harlan-zw harlan-zw mentioned this issue Oct 13, 2022
Merged
7 tasks
@danielroe danielroe mentioned this issue Oct 13, 2022
Closed
7 tasks
@harlan-zw
Copy link
Contributor Author

harlan-zw commented Oct 13, 2022 •
edited

Oops, should have sent the PR first, you're too fast :) I'll close my one

@danielroe danielroe reopened this Oct 13, 2022
@danielroe
Copy link
Member

oops no - let me close mine.

@manniL
Copy link
Member

manniL commented Oct 13, 2022

But I suppose we can close here now after nuxt/framework#8167 got merged? 😋

@danielroe danielroe added the 3.x label Jan 19, 2023
@danielroe danielroe transferred this issue from nuxt/framework Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielroe danielroe

Labels
3.x bug performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf(nuxt)!: use component loader to add meta components nuxt/framework
3 participants
@manniL @harlan-zw @danielroe