Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed CSS preloads shouldn't throw errors #26972

Open
2 of 4 tasks
hecktarzuli opened this issue Apr 26, 2024 · 2 comments
Open
2 of 4 tasks

Failed CSS preloads shouldn't throw errors #26972

hecktarzuli opened this issue Apr 26, 2024 · 2 comments

Comments

@hecktarzuli
Copy link
Contributor

hecktarzuli commented Apr 26, 2024

Describe the feature

Currently in Nuxt 3 if a browser cannot load a CSS file that's loaded via JS it throws an error and the error page is shown.

Error Unable to preload CSS for https://realtruck.com/_nuxt/index-CtQoRL55.css

image

This page has a scoped style that's included in the page.
image

I don't know if this issue is just for page CSS files or what, but I can say that failure to load CSS files should not throw errors. The browser is able to render a page with missing assets (CSS, images, etc..) this should be no different.

Rendering a page, even with some CSS missing is better than showing the error page.

Additional information

  • Would you be willing to help implement this feature?
  • Could this feature be implemented as a module?

Final checks

Copy link
Contributor

Would you be able to provide a reproduction? 🙏

More info

Why do I need to provide a reproduction?

Reproductions make it possible for us to triage and fix issues quickly with a relatively small team. It helps us discover the source of the problem, and also can reveal assumptions you or we might be making.

What will happen?

If you've provided a reproduction, we'll remove the label and try to reproduce the issue. If we can, we'll mark it as a bug and prioritize it based on its severity and how many people we think it might affect.

If needs reproduction labeled issues don't receive any substantial activity (e.g., new comments featuring a reproduction link), we'll close them. That's not because we don't care! At any point, feel free to comment with a reproduction and we'll reopen it.

How can I create a reproduction?

We have a couple of templates for starting with a minimal reproduction:

👉 https://stackblitz.com/github/nuxt/starter/tree/v3-stackblitz
👉 https://codesandbox.io/s/github/nuxt/starter/v3-codesandbox

A public GitHub repository is also perfect. 👌

Please ensure that the reproduction is as minimal as possible. See more details in our guide.

You might also find these other articles interesting and/or helpful:

@hecktarzuli
Copy link
Contributor Author

Stackblitz doesn't seem to trigger the error page quite like our project, but I was able to reproduce a very basic POC using 1 known method to trigger the error. (importing a CSS file into a component/page)

https://stackblitz.com/edit/github-wg3yu6-s33o9j

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants