New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vue-app): null check for $root
access
#9150
fix(vue-app): null check for $root
access
#9150
Conversation
6ec515c
to
e522604
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please provide more info about your issue and how can $root be undefined ?
For me while loading the application, packages/vue-app/template/index.js file is being visited 4 times, but in the last instance $root is becoming undefined. I am not sure why. [(https://github.com//issues/9149)] |
The change itself looks fine, but I think it might hide the root cause which we'd better investigate. /cc @pi0 @danielroe |
It's a little urgent, we have to upgrade from nuxt@2.14.6 very soon to handle some of the vulnerabilities. Would it be possible for you to approve this PR and keep the issue ticket open to keep the root cause analysis under radar? @clarkdo |
@pi0 @danielroe Any idea about this ? |
I agree with @clarkdo. The issue (see also #8359) is likely a consequence of #8170. @PayelKarmakar06 Could you provide a reproduction of your issue using https://template.nuxtjs.org? |
@danielroe as I mentioned earlier, I am not sure why this is happening. I tried to provide a repro already, but was not successful in my attempt. |
Hi @danielroe / @clarkdo / @pi0, |
@danielroe , is there any way to fix it without providing the repro? |
Having a reprodution would be much better but since it is an effect of recent refactor (#8170) let's have it. And sorry for delay @PayelKarmakar06. You can try it by using |
$root
$root
access
@pi0 thanks a lot! |
Types of changes
Description
Resolves: #9149
Checklist: