Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(builder): resolve aliases in build.watch paths #9153

Merged
merged 2 commits into from Apr 15, 2021
Merged

fix(builder): resolve aliases in build.watch paths #9153

merged 2 commits into from Apr 15, 2021

Conversation

danielroe
Copy link
Member

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)

Description

build.watch currently watches relative and absolute paths but doesn't respect aliases (contra to docs example).

This PR resolves aliases in custom watch patterns (from build.watch or build.styleResources).

closes #9045

Checklist:

  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@danielroe danielroe requested a review from pi0 April 14, 2021 22:43
pi0
pi0 approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pi0 pi0 merged commit 9f6131e into dev Apr 15, 2021
@pi0 pi0 deleted the fix/build-watch-paths branch April 15, 2021 19:17
@pi0 pi0 mentioned this pull request May 8, 2021
Closed
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarkdo clarkdo clarkdo approved these changes

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build.watch issues
3 participants
@danielroe @clarkdo @pi0