From 3ed63bb9bad0fdaaff6f93d1096f828fe914bb01 Mon Sep 17 00:00:00 2001 From: Rafal Chlodnicki Date: Fri, 27 Jan 2023 19:20:28 +0100 Subject: [PATCH 1/2] fix(vue-app): unhandled promise rejection when handling asyncData --- packages/vue-app/template/server.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/vue-app/template/server.js b/packages/vue-app/template/server.js index 1ed8a8ceaa23..a7997227be96 100644 --- a/packages/vue-app/template/server.js +++ b/packages/vue-app/template/server.js @@ -321,8 +321,7 @@ const render404Page = () => { promise.then((asyncDataResult) => { ssrContext.asyncData[Component.cid] = asyncDataResult applyAsyncData(Component) - return asyncDataResult - }) + }).catch(() => {}) promises.push(promise) } else { promises.push(null) From f461e36257c71b299fb4af0649ca92021fa323bf Mon Sep 17 00:00:00 2001 From: Rafal Chlodnicki Date: Fri, 17 Feb 2023 13:11:05 +0100 Subject: [PATCH 2/2] better fix? --- packages/vue-app/template/server.js | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/packages/vue-app/template/server.js b/packages/vue-app/template/server.js index a7997227be96..983ec92c4cca 100644 --- a/packages/vue-app/template/server.js +++ b/packages/vue-app/template/server.js @@ -317,15 +317,16 @@ const render404Page = () => { <% if (features.asyncData) { %> // Call asyncData(context) if (Component.options.asyncData && typeof Component.options.asyncData === 'function') { - const promise = promisify(Component.options.asyncData, app.context) - promise.then((asyncDataResult) => { + const promise = promisify(Component.options.asyncData, app.context) + .then((asyncDataResult) => { ssrContext.asyncData[Component.cid] = asyncDataResult applyAsyncData(Component) - }).catch(() => {}) - promises.push(promise) - } else { - promises.push(null) - } + return asyncDataResult + }) + promises.push(promise) + } else { + promises.push(null) + } <% } %> <% if (features.fetch) { %>