From deb049238fa9bff43160f126dd4c651725352377 Mon Sep 17 00:00:00 2001 From: Alexander B Date: Tue, 9 May 2023 14:51:08 +0600 Subject: [PATCH 1/2] fix(nuxt): stop loading indicator on error --- packages/nuxt/src/app/components/nuxt-loading-indicator.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/nuxt/src/app/components/nuxt-loading-indicator.ts b/packages/nuxt/src/app/components/nuxt-loading-indicator.ts index bc591a04f5f4..e3816cd5bc4f 100644 --- a/packages/nuxt/src/app/components/nuxt-loading-indicator.ts +++ b/packages/nuxt/src/app/components/nuxt-loading-indicator.ts @@ -32,6 +32,7 @@ export default defineComponent({ const nuxtApp = useNuxtApp() nuxtApp.hook('page:start', indicator.start) nuxtApp.hook('page:finish', indicator.finish) + nuxtApp.hook('vue:error', indicator.finish) onBeforeUnmount(indicator.clear) return () => h('div', { From b24804a9fc92472ae28875159af5e6aae9025276 Mon Sep 17 00:00:00 2001 From: Alexander B Date: Tue, 9 May 2023 14:52:01 +0600 Subject: [PATCH 2/2] fix(nuxt): call vue:error hook from error boundary --- packages/nuxt/src/app/components/nuxt-error-boundary.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/nuxt/src/app/components/nuxt-error-boundary.ts b/packages/nuxt/src/app/components/nuxt-error-boundary.ts index 22b4c8ea51ff..a58516c1ce82 100644 --- a/packages/nuxt/src/app/components/nuxt-error-boundary.ts +++ b/packages/nuxt/src/app/components/nuxt-error-boundary.ts @@ -11,9 +11,10 @@ export default defineComponent({ const error = ref(null) const nuxtApp = useNuxtApp() - onErrorCaptured((err) => { + onErrorCaptured((err, target, info) => { if (process.client && !nuxtApp.isHydrating) { emit('error', err) + nuxtApp.hooks.callHook('vue:error', err, target, info) error.value = err return false }