Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit type using rollup instead of using tsc directly #85

Open
nvh95 opened this issue Apr 24, 2022 · 1 comment
Open

Emit type using rollup instead of using tsc directly #85

nvh95 opened this issue Apr 24, 2022 · 1 comment
Labels
enhancement Enhancement to current features/ behaviors

Comments

@nvh95
Copy link
Owner

nvh95 commented Apr 24, 2022

Is your feature request related to a problem? Please describe.
Currently, jest preview building process use tsc to emit types directly. It might get complicated if we need to generate types for multiple entries.

Describe the solution you'd like

  • Generate types using rollup
  • Need to be fast in watch mode, so build:watch might not need to generate types (if generating types in watch mode is fast, it's OK to leave it there).

Describe how should jest-preview implements this feature

  • Use rollup plugin to emit types
  • (Optional) Do not emit types in watch mode to save time

Image
image

@nvh95 nvh95 added the enhancement Enhancement to current features/ behaviors label Apr 24, 2022
@nvh95
Copy link
Owner Author

nvh95 commented May 26, 2022

Research to use tsup
Reference: mswjs/msw#1247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to current features/ behaviors
Projects
None yet
Development

No branches or pull requests

1 participant