Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failed on msys2 windows #126

Open
cgwkymt opened this issue Mar 30, 2024 · 1 comment
Open

Build failed on msys2 windows #126

cgwkymt opened this issue Mar 30, 2024 · 1 comment

Comments

@cgwkymt
Copy link

cgwkymt commented Mar 30, 2024

I found the build error during the installation of telescope-fzf-native on MSYS2 UCRT Windows.

Nvim version

NVIM v0.9.5
Build type: Release
LuaJIT 2.1.1710088188

This issue is the same as #101, but I would like to introduce the different workaround.

--- a/Makefile
+++ b/Makefile
@@ -3,8 +3,8 @@ CFLAGS += -Wall -Werror -fpic -std=gnu99
 ifeq ($(OS),Windows_NT)
     CC = gcc
     TARGET := libfzf.dll
-ifeq (,$(findstring MSYS,$(MSYSTEM)))
-   # On Windows, but NOT msys
+ifeq (,$(findstring $(MSYSTEM),MSYS UCRT64 CLANG64 CLANGARM64 CLANG32 MINGW64 MINGW32))
+   # On Windows, but NOT msys/msys2
     MKD = cmd /C mkdir
     RM = cmd /C rmdir /Q /S
 else

The environment variable MSYSTEM can be set to one of the followings:

  • MSYS, UCRT64, CLANG64, CLANGARM64, CLANG32, MINGW64, MINGW32

The build is successful other than CLANGARM64. Although I couldn’t verify it in the CLANGARM64 environment, I believe this patch is fine.

Thank you,

@cgwkymt
Copy link
Author

cgwkymt commented Mar 30, 2024

I encountered this issue during the installation of lazy.vim. lazy.vim just perfoms make without cmake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant