Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make option under installation doesn't work for m1 without alteration #79

Open
jakestrahm opened this issue Jul 28, 2022 · 6 comments
Open

Comments

@jakestrahm
Copy link

following
use {'nvim-telescope/telescope-fzf-native.nvim', run = 'make' }
didn't work on m1.

modifying it to
use {'nvim-telescope/telescope-fzf-native.nvim', run = ' arch -arm64 make' }
worked.

just wanted to share, maybe adding a small note in documentation for people running into the same situation.

@pearofducks
Copy link

pearofducks commented Aug 5, 2022

make is working fine for me on an m1, at least in that it doesn't report any errors or problems on compiling. To my knowledge there's nothing wrong with the artifact it produces either. 🤷

@rkoval
Copy link

rkoval commented Aug 8, 2022

make is working fine for me on an m1, at least in that it doesn't report any errors or problems on compiling. To my knowledge there's nothing wrong with the artifact it produces either.

Same here, though one note I'll add that may be relevant: I had originally set up my M1's vim setup under Rosetta (work tooling compatibility reasons). However, recently, I have been able to drop Rosetta altogether. Once Rosetta was dropped, nvim would load with errors complaining that telescope-fzf-native.nvim hadn't been built for arm64e. I had to remove my build directory for telescope-fzf-native.nvim and then re-run make, but I didn't have to specify any arch flag for it to start working again after that

Not sure if this is relevant in OP's or others' situations, but felt worth sharing

@Conni2461
Copy link
Member

You could try if you had more luck with the cmake builder.

Also maybe we want to integrate this: #23 (comment) the person who mentioned a fork said that adding -target arm64-apple-macos11 fixes things. I can not test this, because i do not have a m1 available, but maybe someone else wants to pick it up, should be just two ifs, first check for macos and second check for architecture.

PR welcome :)

@marcoSven
Copy link

A quick alternative solution that worked for me on M1 is using gmake installed via https://formulae.brew.sh/formula/make

{"nvim-telescope/telescope-fzf-native.nvim", build = "gmake"} - folke/lazy

@raphaelchristin
Copy link

gmake worked for me too! Interestingly, I have never had any issues with this before updating telescope earlier today.

@rywng
Copy link

rywng commented Jan 3, 2024

Alternative solution, without gmake:

#119 (comment)

maybe we should add docs in the readme to help users on apple SoC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants