Skip to content
This repository has been archived by the owner on Jun 22, 2022. It is now read-only.

[Feature request] File input #47

Open
rejifald opened this issue Feb 8, 2019 · 13 comments
Open

[Feature request] File input #47

rejifald opened this issue Feb 8, 2019 · 13 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@rejifald
Copy link
Contributor

rejifald commented Feb 8, 2019

File picker with previews will be great. For example https://lusaxweb.github.io/vuesax/components/upload.html#default

@rejifald
Copy link
Contributor Author

rejifald commented Feb 8, 2019

Btw, will be also great to merge all inputs in one input with type attribute.
Just as native input works.
Wdyt ?

@nvms
Copy link
Owner

nvms commented Feb 8, 2019

good idea. if (when) this is implemented, it will be as a <va-input type="file" ... />

@nvms nvms self-assigned this Feb 8, 2019
@nvms nvms added enhancement New feature or request help wanted Extra attention is needed labels Feb 8, 2019
@nvms nvms added this to To do in Short-term roadmap Feb 9, 2019
@nvms nvms moved this from Considerations to Top priorities in Short-term roadmap Feb 9, 2019
@nvms nvms moved this from Top priorities to 2.1.0 (in progress) in Short-term roadmap Feb 16, 2019
@rejifald
Copy link
Contributor Author

rejifald commented Feb 20, 2019

Do u work with this ?
If no, let's discuss about component feature and interface, and i am open to contribute.

@nvms
Copy link
Owner

nvms commented Feb 20, 2019

I haven't had time to work on this yet. still exploring ideas. I'm not sure how it would even look quite yet

@rejifald
Copy link
Contributor Author

It can be button with appropriate icon, and filename when file is picked

@rejifald
Copy link
Contributor Author

But in other hand, there should accept drag and drop, and file preview. Helpful for images, but it may use appropriate icon for common file types.
Documents, videos, audio, etc.

@rejifald
Copy link
Contributor Author

Have u design system ? Which u use.

@rejifald
Copy link
Contributor Author

screen shot 2019-02-20 at 11 44 37 pm

screen shot 2019-02-20 at 11 44 22 pm

Few examples of such component that i created for a long time ago.

@nvms
Copy link
Owner

nvms commented Feb 20, 2019

looks nice, if you'd like to work on this then please go ahead. if you do decide to work on this, please try and make it appear visually similar to the current button/input styles

some thoughts:

  • automatic preview of images should be optional
  • drag and drop target should be its own component?

@rejifald
Copy link
Contributor Author

Let's postpone drag and drop for now.
I completely agree that it should looks like current design.
Do u have design system or something like that ? If no, i just will try to make it similar with current design.

@nvms
Copy link
Owner

nvms commented Feb 20, 2019

I do not have a design system, so you'll have to use your best judgement

@rejifald
Copy link
Contributor Author

Ok, will do

@rejifald
Copy link
Contributor Author

I am working on it. I've implemented component almost fully. I'm just working under it's style.
And i'm gonna to use ToggleIcon and Buttons with prefix/postfix on this file picker.

@rejifald rejifald mentioned this issue Feb 22, 2019
8 tasks
@nvms nvms changed the title FR file input [Feature request] File input Feb 23, 2019
@nvms nvms assigned rejifald and unassigned nvms Feb 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Short-term roadmap
  
2.2.x (in progress)
Development

No branches or pull requests

2 participants