Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the exit code #50

Open
jaredmcateer opened this issue Aug 6, 2016 · 2 comments
Open

Setting the exit code #50

jaredmcateer opened this issue Aug 6, 2016 · 2 comments

Comments

@jaredmcateer
Copy link

I am maintaining an app that relies on the exit code to change based on certain conditions, even though the nw app itself closes cleanly, as it is spawned by a parent process that monitors it. Currently we've an older version of node-webkit forked with the following change and I'm trying to upgrade. Do you have any desire for a PR that changes

bin/nw:

 // Spawn node-webkit
  var nw = spawn(bin, args, { stdio: 'inherit' });
  nw.on('close', function() {
    process.nextTick(function() {
      process.exit(0);
    });
  });

to

  // Spawn node-webkit
  var nw = spawn(bin, args, { stdio: 'inherit' });
  nw.on('close', function(code) {
    process.nextTick(function() {
      process.exit(code);
    });
  });

Better yet if there's a way to achieve this with the existing code that would be great too. My problem is maintaining a downstream fork that will make this simple change every time there is a release of this repository.

@Mithgol
Copy link
Contributor

Mithgol commented Aug 12, 2016

Looks like a good idea. (I'd accept such pull request.)

@Mithgol
Copy link
Contributor

Mithgol commented Mar 29, 2018

@jaredmcateer Ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants