Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic "getHash" helper #57

Open
webrgp opened this issue Jan 30, 2023 · 1 comment
Open

Generic "getHash" helper #57

webrgp opened this issue Jan 30, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@webrgp
Copy link

webrgp commented Jan 30, 2023

Is your feature request related to a problem? Please describe.

The existing getCssHash won't return the hash if the css ins't included in a javascript entry.

Describe the solution you would like

Create a getHash that would behave just the same BUT it wouldn't check the "type" here, but just return the hash based on the filename returned from the manifest.

Additional context

This would allow us to have css entries (per v4.0.5) but still implement critical cookies.
@webrgp webrgp added the enhancement New feature or request label Jan 30, 2023
@khalwat
Copy link
Contributor

khalwat commented Mar 1, 2023

Given their changes to the manifest, probably this makes sense.

Have you removed that single line of code that tests the tag type? Does it work for your purposes with that removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@webrgp @khalwat