Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brotli Compression #37

Open
acalvino4 opened this issue Oct 23, 2021 · 3 comments
Open

Brotli Compression #37

acalvino4 opened this issue Oct 23, 2021 · 3 comments

Comments

@acalvino4
Copy link

Is your feature request related to a problem? Please describe.

As Brotli compression has better performance than gzip and has 95% browser support now, it would be really nice to have it available in this config.

Describe alternatives you have considered

Obviously I can modify the config here to set it up myself, but since a lot of people use this config, I'm guessing it would be a welcome improvement to the base config here.

@khalwat
Copy link
Contributor

khalwat commented Oct 24, 2021

Agreed. PRs are very welcome!

@acalvino4
Copy link
Author

@khalwat we are finally having some time to work on this - anything particular you would like to see in a PR? I was thinking we'd just add the brotli config options to compression.conf with similar settings to what is there for gzip. How does that sound?

@acalvino4
Copy link
Author

On second thought I am thinking we rename compression.conf to gzip.conf and add a separate brotli.conf so that people can selectively enable/disable brotli by changing the file extension to .off. This may be necessary for people who are not quite yet on the newest nginx version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants