Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External references are being inlined #118

Open
elyashivlavi opened this issue Nov 17, 2019 · 0 comments
Open

External references are being inlined #118

elyashivlavi opened this issue Nov 17, 2019 · 0 comments

Comments

@elyashivlavi
Copy link

According to the fix was made in #27,
Now external references are being inlined.
This means that if I have such a spec:

paths:
  /path1:
    parameters:
        - $ref: 'param1.yaml'
  /path2
    parameters:
       - $ref: 'param1.yaml'

Then I will end with 2 inner messages Param1 in the protofile, instead of reusing the existing one... Is this intentional?
I assume it can be changed easily by adding external references to the 'definitions' section of the scheme, instead of inlining them (in external.go file).
WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant