Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid protobuf files in fixtures/ #130

Open
curiousleo opened this issue Sep 20, 2020 · 3 comments
Open

Invalid protobuf files in fixtures/ #130

curiousleo opened this issue Sep 20, 2020 · 3 comments

Comments

@curiousleo
Copy link

protoc v3.7.1 throws errors when parsing fixtures/accountv1-0.proto:

$ protoc --version
libprotoc 3.7.1
$ protoc -o/dev/null fixtures/accountv1-0.proto
fixtures/accountv1-0.proto:342:14: "Permissions" is already defined in "accountinformationapis.AccountRequest.DataMessage".
fixtures/accountv1-0.proto:646:14: "Permissions" is already defined in "accountinformationapis.CreateAccountRequest.DataMessage".
fixtures/accountv1-0.proto:362:18: "Permissions" is not defined.
fixtures/accountv1-0.proto:672:18: "Permissions" is not defined.
fixtures/accountv1-0.proto:1004:68: "CreateAccountRequest" is not a message type.
fixtures/accountv1-0.proto:1014:20: "GetAccountRequest" is not a message type.
fixtures/accountv1-0.proto:1039:62: "CreateAccountRequest" is not a message type.
$ echo $?
1
@curiousleo
Copy link
Author

books.proto is also incomplete:

books.proto:361:26: "GETReviewsFormatRequest" is not defined.
books.proto:361:60: "GETReviewsFormatResponse" is not defined.

@curiousleo
Copy link
Author

curiousleo commented Sep 20, 2020

kubernetes.proto has over a thousand "... is not defined" errors.

Note: the updated kubernetes.proto in #129 passes protoc validation.

@curiousleo
Copy link
Author

See https://travis-ci.org/github/nytimes/openapi2proto/jobs/728735641#L158 for all validation failures on master.

@curiousleo curiousleo changed the title fixtures/accountv1-0.proto is not a valid protobuf file Invalid protobuf files in fixtures/ Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant