Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

True color support not recognized on Windows Terminal #1199

Open
1 task done
lomirus opened this issue Nov 2, 2023 · 6 comments
Open
1 task done

True color support not recognized on Windows Terminal #1199

lomirus opened this issue Nov 2, 2023 · 6 comments
Labels
bug Something isn't working pinned

Comments

@lomirus
Copy link

lomirus commented Nov 2, 2023

Duplicates

  • I have searched the existing issues

Current behavior 馃槸

In windows terminal:
QQ鎴浘20231102192629

The dart is red, and the rust is green

Expected behavior 馃

But in the VSCode terminal, it displays as expected:

QQ鎴浘20231102192637

Steps to reproduce 馃暪

Open windows terminal and run onefetch

Additional context/Screenshots 馃敠

No response

Possible Solution 馃挕

Using VSCode terminal

@lomirus lomirus added the bug Something isn't working label Nov 2, 2023
@spenserblack
Copy link
Collaborator

spenserblack commented Nov 2, 2023

The results you're seeing in the Windows terminal is most likely because that terminal instance doesn't support truecolor. Or, perhaps more accurately, our tools don't think your terminal supports truecolor. When the language bar can't display the exact color, we fall back to the simple colors. See #585 for context. So I see two possible solutions

  1. Get better at detecting if the terminal supports true color (bug fix, possibly upstream)
  2. Pick better colors when the terminal doesn't support true color (feature request) I think we've discussed this before, and decided that we need to cycle arbitrary colors to distinguish languages that would have the same simple color

@spenserblack
Copy link
Collaborator

As a current workaround, try onefetch --true-color always and let us know if it looks good 馃檪

@spenserblack spenserblack changed the title Incorrect language color True color support not recognized on Windows Terminal Nov 2, 2023
@lomirus
Copy link
Author

lomirus commented Nov 3, 2023

QQ鎴浘20231103104514

Windows terminal supports true color. It seems to be a detecting problem.

@o2sh
Copy link
Owner

o2sh commented Nov 3, 2023

You're correct @lomirus 馃憤

We're discussing the problem over here 馃憠 #1200

@o2sh
Copy link
Owner

o2sh commented Jan 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@o2sh o2sh added the stale label Jan 7, 2024
@spenserblack
Copy link
Collaborator

IMO this issue should remain open for now. Should it be pinned?

@spenserblack spenserblack removed the stale label Jan 7, 2024
@o2sh o2sh added the pinned label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pinned
Projects
None yet
3 participants