Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make newline characters consistent across the codebase #196

Open
ivan444 opened this issue Aug 30, 2020 · 0 comments · May be fixed by #197
Open

Make newline characters consistent across the codebase #196

ivan444 opened this issue Aug 30, 2020 · 0 comments · May be fixed by #197

Comments

@ivan444
Copy link

ivan444 commented Aug 30, 2020

chessboardjs codebase is using a mix of Unix & Windows line terminators. Example:

file lib/chessboard.js
lib/chessboard.js: UTF-8 Unicode text, with CRLF, LF line terminators

This leads to an awkward diff when using editors which force-correct the line terminators (a common option).

Change the code to use a single type of line terminators (will send a PR shortly).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mixed line endings. Switch all files under data/* examples/* lib/… ivan444/chessboardjs
1 participant
@ivan444