Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate body { type: "stream" } not tee'ing the stream #492

Open
kitsonk opened this issue Mar 12, 2022 · 1 comment
Open

Investigate body { type: "stream" } not tee'ing the stream #492

kitsonk opened this issue Mar 12, 2022 · 1 comment
Labels
needs investigation Something that needs to be looked at

Comments

@kitsonk
Copy link
Collaborator

kitsonk commented Mar 12, 2022

As discussed in #491 when requesting a body type of "stream", memory takes a thrashing because the body stream is .tee()ed. Should investigate just passing the body stream back, allowing it to be locked, as I am not sure there is any real benefit in tee'ing it, because we don't do that when the body is a "reader" for example, we just lock the stream.

@kitsonk kitsonk added the needs investigation Something that needs to be looked at label Mar 12, 2022
@bodograumann
Copy link
Contributor

Just saw this issue :-). It is resolved in oak 13 and later, but see also #642 as a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs investigation Something that needs to be looked at
Projects
None yet
Development

No branches or pull requests

2 participants