Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Profile form validation #1925

Closed
buberdds opened this issue May 8, 2024 · 2 comments · Fixed by #1936
Closed

Create Profile form validation #1925

buberdds opened this issue May 8, 2024 · 2 comments · Fixed by #1936
Labels
ux Usability, user experience etc.

Comments

@buberdds
Copy link
Contributor

buberdds commented May 8, 2024

When required form inputs are empty we should show some feedback when user clicks submit button. Currently, nothing happens.
Screenshot from 2024-05-08 12-40-03
@buberdds buberdds added the ux Usability, user experience etc. label May 8, 2024
@lukaw3d
Copy link
Member

lukaw3d commented May 11, 2024

Related to #1913

oasis-wallet-web/src/styles/theme/ThemeProvider.tsx

Lines 278 to 286 in 545a5f1

toggle: {
color: {
dark: 'text',
light: 'grayMedium',
},
},
border: {
color: 'text',
},

Without customized colors:
Peek 2024-05-11 03-17

Or move required from CheckBox to FormField and customize the error message:
image

@lukaw3d
Copy link
Member

lukaw3d commented May 15, 2024

If checkbox is not wrapped in FormField it also shows focus:
image

@lukaw3d lukaw3d mentioned this issue May 15, 2024
Merged
@buberdds buberdds mentioned this issue May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ux Usability, user experience etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add validation message to required checkbox in ChoosePasswordFields oasisprotocol/oasis-wallet-web
2 participants
@buberdds @lukaw3d