BODY_DTO fails to correctly parse "false" for Boolean

[OneDevTwoDev]

Observing some strange behavior when trying to parse a body dto for an endpoint which contains a single boolean value. Value is correctly parsed when equal to true, but fails when equal to false. Wondering if this is related to 673.

Issue is reproducible with a controller w/ the following structure:

ENDPOINT("PUT", "/set_flag", setFlag, BODY_DTO(Boolean, aBool))
{
  std::cout << "param = " << *aBool << std::endl;
  return createResponse(Status::CODE_200, "OK");
}

When sending a request to this endpoint w/ a request body of "false", a 400 error is generated. When sending a request w/ a request body of "true", the boolean is correctly parsed.

I'm suspicious of the following section:

oatpp/src/oatpp/codegen/api_controller/base_define.hpp

Lines 243 to 245 in 57e6a71

	if(!OATPP_MACRO_FIRSTARG PARAM_LIST) { \
	throw oatpp::web::protocol::http::HttpError(Status::CODE_400, "Missing valid body parameter '" OATPP_MACRO_FIRSTARG_STR PARAM_LIST "'"); \
	}

Suspect that check should compare to nullptr similar to fix for 673.

[OneDevTwoDev]

When modifying the body parameter check mentioned above to the following:

if(OATPP_MACRO_FIRSTARG PARAM_LIST != nullptr) {
  throw oatpp::web::protocol::http::HttpError(Status::CODE_400, "Missing valid body parameter '" OATPP_MACRO_FIRSTARG_STR PARAM_LIST "'");
}

I noticed I also needed to declare one of the operator!= definitions as const in the base DTOWrapper class:

oatpp/src/oatpp/core/data/mapping/type/Object.hpp

Lines 357 to 369 in 57e6a71

	template<typename T,
	typename enabled = typename std::enable_if<std::is_same<T, std::nullptr_t>::value, void>::type
	>
	inline bool operator == (T){
	return this->m_ptr.get() == nullptr;
	}
	template<typename T,
	typename enabled = typename std::enable_if<std::is_same<T, std::nullptr_t>::value, void>::type
	>
	inline bool operator != (T){
	return this->m_ptr.get() != nullptr;
	}

I suspect this is because the variable specified in the BODY_DTO macro has a const modifier:

oatpp/src/oatpp/codegen/api_controller/base_define.hpp

Lines 241 to 242 in 57e6a71

	const auto& OATPP_MACRO_FIRSTARG PARAM_LIST = \
	__request->readBodyToDto<TYPE>(getDefaultObjectMapper().get()); \

Couldn't think of a reason why making this method const would break anything and suspect it may need to be part of a fix for this issue.