Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect connectionUrl type #96

Open
artemiyokulov opened this issue Apr 21, 2022 · 7 comments
Open

incorrect connectionUrl type #96

artemiyokulov opened this issue Apr 21, 2022 · 7 comments

Comments

@artemiyokulov
Copy link

In template expecting string https://github.com/oauth2-proxy/manifests/blob/oauth2-proxy-6.2.0/helm/oauth2-proxy/templates/deployment.yaml#L142

but in docs (https://github.com/oauth2-proxy/manifests/tree/main/helm/oauth2-proxy) descibed as a list

@pierluigilenoci
Copy link
Contributor

@artemiyokulov would you like to open a PR to solve it?

@pierluigilenoci
Copy link
Contributor

@artemiyokulov what about this?

@pierluigilenoci
Copy link
Contributor

@artemiyokulov any update on this?

@pierluigilenoci
Copy link
Contributor

@desaintmartin this would seem to make sense.

@pierluigilenoci
Copy link
Contributor

@artemiyokulov would you like to open a PR for this?

@pierluigilenoci
Copy link
Contributor

@desaintmartin, could you please take a look?

@pierluigilenoci
Copy link
Contributor

@artemiyokulov This parameter is passed to the OAuth2-Proxy ad environment variable, so it should be a well-formed string interpreted as an array by the software.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants