[Bug]: Possible typo in source code for static upstreams

[anonhostpi]

OAuth2-Proxy Version

v7.6.0

Provider

None

Expected Behaviour

As far as I am aware, there is no reason that static URIs should host web socket connections.

According to this line, if Upstream.ProxyWebSockets is set to nil, it should use the default behavior (not false), which is to proxy any web socket connections to that Upstream

• see:

  oauth2-proxy/pkg/upstream/http.go

  Line 56 in fc701bf

  if upstream.ProxyWebSockets == nil || *upstream.ProxyWebSockets {

Current Behaviour

However according to the source code, when using a "static" URI upstream, it uses sets ProxyWebSockets to nil instead of false, which means that it will proxy web socket connections to the static file (which doesn't make sense):

switch u.Scheme {
...
case "static":
...
  upstream.ProxyWebSockets = nil # probably got `nil` confused with `false`

• see:

  oauth2-proxy/pkg/apis/options/legacy_options.go

  Lines 157 to 178 in fc701bf

  	case "static":
  	responseCode, err := strconv.Atoi(u.Host)
  	if err != nil {
  	logger.Errorf("unable to convert %q to int, use default \"200\"", u.Host)
  	responseCode = 200
  	}
  	upstream.Static = true
  	upstream.StaticCode = &responseCode
  	// This is not allowed to be empty and must be unique
  	upstream.ID = upstreamString
  	// We only support the root path in the legacy config
  	upstream.Path = "/"
  	// Force defaults compatible with static responses
  	upstream.URI = ""
  	upstream.InsecureSkipTLSVerify = false
  	upstream.PassHostHeader = nil
  	upstream.ProxyWebSockets = nil
  	upstream.FlushInterval = nil
  	upstream.Timeout = nil

Steps To Reproduce

I discovered this while reviewing source code. I don't quite yet have a way to test if this is genuinely an issue.

Possible Solutions

Set Upstream.ProxyWebSockets to false instead of nil for static URIs

Configuration details or additional information

No response

[anonhostpi]

Oh I just realized the static:// URI format is used for status codes, and not files. I'm still not entirely sure why web sockets would be proxied for HTTP status codes.

[anonhostpi]

This also makes me think that setting it to nil instead of false was unintentional:

oauth2-proxy/pkg/validation/upstreams.go

Line 79 in fc701bf

msgs = append(msgs, fmt.Sprintf("upstream %q has proxyWebSockets, but is a static upstream, this will have no effect.", upstream.ID))