Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify nonce protection in 4.5.3.2 #98

Closed
aaronpk opened this issue May 11, 2024 · 3 comments
Closed

Clarify nonce protection in 4.5.3.2 #98

aaronpk opened this issue May 11, 2024 · 3 comments

Comments

@aaronpk
Copy link
Contributor

aaronpk commented May 11, 2024

https://datatracker.ietf.org/doc/html/draft-ietf-oauth-security-topics#section-4.5.3.2

It took me an extra read to notice that the sentence

The OP puts the received nonce value into the ID Token that is issued as part of the code exchange at the token endpoint.

means that the ID token was received from the token endpoint, and doesn't apply to the ID token received from the redirect via response_type=code+id_token.

I think this section would benefit from being explicit that this nonce protection only applies to an ID token obtained from the token endpoint, otherwise it is easy to misinterpret this to mean that the client should check the nonce in the ID token it got in the redirect, which would of course do nothing. I do realize this is spelled out pretty clearly in the numbered list below, but I think it should be made clearer up front as well.

@selfissued
Copy link
Collaborator

That's not the case. The provided nonce must be included in all ID Tokens, no matter what response_type was used.

@aaronpk
Copy link
Contributor Author

aaronpk commented May 11, 2024

Yes that's not what I meant. I meant the language that says the client must validate the nonce in the ID token, it's not clear that it has to use an option that gets an ID token from the token endpoint in the first paragraph.

@danielfett
Copy link
Collaborator

Thanks for raising this, I created PR #99 to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants