Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eo-runtime must not have ANY non-test dependencies #2684

Closed
yegor256 opened this issue Dec 7, 2023 · 11 comments · Fixed by #2703
Closed

eo-runtime must not have ANY non-test dependencies #2684

yegor256 opened this issue Dec 7, 2023 · 11 comments · Fixed by #2703
Assignees
Labels

Comments

@yegor256
Copy link
Member

yegor256 commented Dec 7, 2023

The resolve goal in our plugin can't deal with JAR artifacts that have transitive dependencies. It simply ignores them. However, commons-text was added to eo-runtime, by mistake. Let's 1) delete it from there, and 2) introduce a check into the build of eo-runtime (together with documentation) that would prevent this from happening in the future.

@yegor256
Copy link
Member Author

yegor256 commented Dec 7, 2023

@maxonfjvipon please, help us here

@yegor256
Copy link
Member Author

yegor256 commented Dec 9, 2023

@maxonfjvipon
Copy link
Member

@yegor256 we have ignoreTransitive flag in ResolveMojo. The default value is false. Could you please provide more details or scenario where we have a wrong behaviour with the flag?

@yegor256
Copy link
Member Author

yegor256 commented Dec 12, 2023

@maxonfjvipon the flag works only for dependencies that are not eo-runtime. It works for those packages that we resolve, like eo-strings, etc. Thus, eo-runtime is unpackaged but its dependencies are ignored. This is the log I'm getting:

java.lang.NoClassDefFoundError: org/apache/commons/text/StringEscapeUtils
      at org.eolang.Data$ToPhi.toPhi (Data.java:237)
      at org.eolang.Data$ToPhi.<init> (Data.java:161)
      at org.eolang.PhSafe.attr (PhSafe.java:93)
      at org.eolang.PhNamed.attr (PhNamed.java:88)
      at org.eolang.PhSafe.attr (PhSafe.java:90)

Here: https://github.com/objectionary/eo/actions/runs/7126950802/job/19405845463

@yegor256
Copy link
Member Author

@maxonfjvipon maybe the flag should also work for eo-runtime, but currently it doesn't

@yegor256
Copy link
Member Author

@maxonfjvipon this bug holds this ticket: objectionary/normalizer-maven-plugin#4

@0pdd
Copy link

0pdd commented Dec 15, 2023

@yegor256 the puzzle #2702 is still not solved.

@0pdd
Copy link

0pdd commented Dec 15, 2023

@yegor256 the only puzzle #2702 is solved here.

@yegor256
Copy link
Member Author

@rultor release, tag is 0.34.1

@rultor
Copy link
Contributor

rultor commented Dec 17, 2023

@rultor release, tag is 0.34.1

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Dec 17, 2023

@rultor release, tag is 0.34.1

@yegor256 Done! FYI, the full log is here (took me 30min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants