Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2714: loggingOfErrors #2870

Merged
merged 6 commits into from Feb 13, 2024
Merged

#2714: loggingOfErrors #2870

merged 6 commits into from Feb 13, 2024

Conversation

levBagryansky
Copy link
Member

@levBagryansky levBagryansky commented Feb 7, 2024 •
edited by pr-codex bot

Closes #2714
Prints warnings in format:

[WARNING] eo-runtime/src/test/eo/org/eolang/switch-tests.eo, line 101: Sparse decoration is prohibited
[WARNING] eo-runtime/src/test/eo/org/eolang/int-tests.eo, line 26: Package org.eolang is reserved for internal object only
[WARNING] eo-runtime/src/test/eo/org/eolang/memory-tests.eo, line 26: Package org.eolang is reserved for internal object only
[WARNING] eo-runtime/src/test/eo/org/eolang/try-tests.eo, line 52: Sparse decoration is prohibited
[WARNING] eo-runtime/src/test/eo/org/eolang/heap-tests.eo, line 26: Package org.eolang is reserved for internal object only
[WARNING] eo-runtime/src/test/eo/org/eolang/negative-infinity-tests.eo, line 25: Package org.eolang is reserved for internal object only
[WARNING] eo-runtime/src/test/eo/org/eolang/cti-test.eo, line 32: This method is deprecated!

PR-Codex overview

Focus of the PR:

This PR focuses on adding a method to log errors of XML in the VerifyMojo class.

Detailed summary:

  • Added import statement for com.jcabi.xml.XML.
  • Added a new method logErrors to log errors of XML.
  • The logErrors method takes an XML parameter and returns XML.
  • The logErrors method iterates over the XML nodes to log errors.
  • The severity of each error is checked and corresponding logging action is taken.
  • The logErrors method returns the modified XML.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@levBagryansky
Copy link
Member Author

@maxonfjvipon please take a look

@levBagryansky
Copy link
Member Author

@maxonfjvipon please take a look

maxonfjvipon
maxonfjvipon approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@maxonfjvipon maxonfjvipon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levBagryansky precious! Thanks

@levBagryansky
Copy link
Member Author

@yegor256 please check

1 similar comment
@levBagryansky
Copy link
Member Author

@yegor256 please check

@yegor256
Copy link
Member

yegor256 commented Feb 8, 2024

@rultor merge

@rultor
Copy link
Contributor

rultor commented Feb 8, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Feb 8, 2024

@rultor merge

@levBagryansky @yegor256 Oops, I failed. You can see the full log here (spent 4min)

Reading paper/sections/overview.tex ...
Reading paper/sections/pragmatics.tex ...
Reading paper/sections/related.tex ...
Reading paper/sections/semantics.tex ...
Reading paper/sections/syntax.tex ...
Reading paper/sections/xmir.tex ...
Reading pom.xml ...
Puzzle 2171-74d15acf 30/DEV at pom.xml
Reading src/test/groovy/check-xsl-id.groovy ...
Reading src/test/groovy/check-xsl-version.groovy ...
Reading src/test/groovy/verify.groovy ...
Reading src/test/scripts/test-repetition.sh ...
Fetching pdd-0.23.2.gem
Successfully installed pdd-0.23.2
1 gem installed

A new release of RubyGems is available: 3.4.10 → 3.5.6!
Run `gem update --system 3.5.6` to update your installation.

Fetching texsc-0.6.0.gem
Fetching backtrace-0.4.0.gem
Fetching loog-0.5.1.gem
Successfully installed loog-0.5.1
Successfully installed backtrace-0.4.0
Successfully installed texsc-0.6.0
3 gems installed
Fetching texqc-0.6.0.gem
Fetching slop-4.8.2.gem
Successfully installed slop-4.8.2
Successfully installed texqc-0.6.0
2 gems installed
Using /usr/local/rvm/gems/ruby-3.2.2
Using /usr/local/rvm/gems/ruby-3.2.2
tlmgr: setting default package repository to https://mirror.ctan.org/systems/texlive/tlnet
tlmgr: updating /usr/local/texlive/2023/tlpkg/texlive.tlpdb
Using /usr/local/rvm/gems/ruby-3.2.2
Using /usr/local/rvm/gems/ruby-3.2.2
tlmgr: package repository https://ctan.mc1.root.project-creative.net/systems/texlive/tlnet (not verified: gpg unavailable)
tlmgr: saving backups to /usr/local/texlive/2023/tlpkg/backups
[1/1, ??:??/??:??] update: texlive.infra [553k] (66822 -> 69666) ... done
running mktexlsr ...
done running mktexlsr.
tlmgr: package log updated: /usr/local/texlive/2023/texmf-var/web2c/tlmgr.log
tlmgr: command log updated: /usr/local/texlive/2023/texmf-var/web2c/tlmgr-commands.log
Using /usr/local/rvm/gems/ruby-3.2.2
Using /usr/local/rvm/gems/ruby-3.2.2
tlmgr: package repository https://mirror.clientvps.com/CTAN/systems/texlive/tlnet (not verified: gpg unavailable)
===============================================================================
tlmgr itself needs to be updated.
Please do this via either
  tlmgr update --self
or by getting the latest updater for Unix-ish systems:
  https://mirror.ctan.org/systems/texlive/tlnet/update-tlmgr-latest.sh
and/or Windows systems:
  https://mirror.ctan.org/systems/texlive/tlnet/update-tlmgr-latest.exe
Then continue with other updates as usual.
===============================================================================
tlmgr: Terminating; please see warning above!
container d7cecc220e85b5819ff92cf7c943becd5616a69d52fe29956dac947958d63a0f is dead
Thu Feb  8 03:33:30 PM CET 2024

@levBagryansky
Copy link
Member Author

@yegor256 could you please try again

@levBagryansky
Copy link
Member Author

@yegor256 please check

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Feb 12, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Feb 12, 2024

@rultor merge

@levBagryansky @yegor256 Oops, I failed. You can see the full log here (spent 5min)

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Feb 12, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Feb 12, 2024

@rultor merge

@levBagryansky @yegor256 Oops, I failed. You can see the full log here (spent 5min)

@levBagryansky
Copy link
Member Author

@yegor256 seems rultor has issues with merging to the repository. See #2869 with thee same problem

@yegor256
Copy link
Member

@rultor merge

@yegor256
Copy link
Member

@levBagryansky it's not rultor, it's CTAN TeXlive repository.

@rultor
Copy link
Contributor

rultor commented Feb 12, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Feb 12, 2024

@rultor merge

@levBagryansky @yegor256 Oops, I failed. You can see the full log here (spent 4min)

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Feb 12, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Feb 12, 2024

@rultor merge

@levBagryansky @yegor256 Oops, I failed. You can see the full log here (spent 11min)

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Feb 12, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Feb 12, 2024

@rultor merge

@levBagryansky @yegor256 Oops, I failed. You can see the full log here (spent 23min)

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Feb 12, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Contributor

rultor commented Feb 12, 2024

@rultor merge

@levBagryansky @yegor256 Oops, I failed. You can see the full log here (spent 22min)

@yegor256 yegor256 merged commit 1da912b into objectionary:master Feb 13, 2024
15 checks passed
@yegor256
Copy link
Member

@levBagryansky thanks!

@levBagryansky levBagryansky deleted the 2714_log-warnings branch February 19, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxonfjvipon maxonfjvipon maxonfjvipon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VerifyMojo doesn't log warnings, but simply ignores them
4 participants
@levBagryansky @yegor256 @rultor @maxonfjvipon