Call remove on ThreadLocal variable when no longer need.
#2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@c71n93 what's up with this one? |
|
@maxonfjvipon there are more critical problems with Sonar, so we can just close this one for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2887. This should fix the corresponding reliability issue from Sonar.
PR-Codex overview
This PR adds a
cleanUpmethod toPhPackage.javato release resources and prevent memory leaks.Detailed summary
cleanUpmethod to release resources inPhPackage.javaThreadLocal#remove()to prevent memory leaks