Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let's get rid of the nop object #3069

Closed
yegor256 opened this issue Apr 9, 2024 · 3 comments · Fixed by #3076
Closed

Let's get rid of the nop object #3069

yegor256 opened this issue Apr 9, 2024 · 3 comments · Fixed by #3076
Assignees
@levBagryansky
Labels
bug

Comments

@yegor256
Copy link
Member

yegor256 commented Apr 9, 2024

We don't have varargs anymore. That's why, the nop object doesn't make much sense. Moreover, we don't use it anywhere.
@yegor256 yegor256 added the bug label Apr 9, 2024
@yegor256
Copy link
Member Author

yegor256 commented Apr 9, 2024

@maxonfjvipon WDYT?

@maxonfjvipon
Copy link
Member

maxonfjvipon commented Apr 9, 2024 •
edited

@yegor256 it's used in try as finally object, but we can use just TRUE instead. So I agree, we can remove it

@levBagryansky
Copy link
Member

@maxonfjvipon I can do it

levBagryansky added a commit to levBagryansky/eo that referenced this issue Apr 10, 2024
@levBagryansky
objectionary#3069: Removed nop
2ce87c2
@levBagryansky levBagryansky mentioned this issue Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@levBagryansky levBagryansky

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3069: Removed nop levBagryansky/eo
3 participants
@yegor256 @levBagryansky @maxonfjvipon