Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash due to a regression in nwsapi (“Unexpected error: 'h1:not(:first-of-type),…' is not a valid selector”) #1330

Closed
Fil opened this issue May 13, 2024 · 2 comments · Fixed by #1332
Labels
bug Something isn’t working

Comments

@Fil
Copy link
Contributor

Fil commented May 13, 2024

If you experience this issue, please upgrade Observable Framework to 1.7.1 (release notes)


see dperini/nwsapi#114

this breaks the build of any project that has nwsapi@2.2.10 (2.2.9 is OK).

@Fil Fil added the bug Something isn’t working label May 13, 2024
@Fil
Copy link
Contributor Author

Fil commented May 13, 2024

tip from @mootari : add the following to package.json:

  "overrides": { "nwsapi": "<2.2.10" },
  "resolutions": { "nwsapi": "<2.2.10" }

this will cover both yarn and npm.
Then run yarn install / npm install again.

@mootari
Copy link
Member

mootari commented May 13, 2024

Note that 2.2.8 also has a regression (it fails for "h1,h2"), so 2.2.9 appears to be the only safe version for now.

@Fil Fil pinned this issue May 13, 2024
@mootari mootari changed the title regression in nwsapi Regression in nwsapi: "not a valid selector" May 13, 2024
@Fil Fil changed the title Regression in nwsapi: "not a valid selector" crash due to a regression in nwsapi (“Unexpected error: 'h1:not(:first-of-type),…' is not a valid selector”) May 13, 2024
@mbostock mbostock unpinned this issue May 14, 2024
@mbostock mbostock pinned this issue May 14, 2024
@mbostock mbostock unpinned this issue May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn’t working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants