Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty facet domain causes rendering errors #1856

Open
mbostock opened this issue Sep 12, 2023 · 0 comments · May be fixed by #1864
Open

Empty facet domain causes rendering errors #1856

mbostock opened this issue Sep 12, 2023 · 0 comments · May be fixed by #1864
Labels
bug Something isn’t working

Comments

@mbostock
Copy link
Member

Looks like we don’t handle this case very gracefully:

untitled (82)

Plot.rectY([], { x: "date", y: "visitors", fy: "path" }).plot()

From the console:

Error: <svg> attribute height: Expected length, "NaN".
Error: <svg> attribute viewBox: Expected number, "0 0 640 NaN".
Error: <text> attribute transform: Trailing garbage, "translate(600,NaN) rotate(-90)".
Error: <text> attribute transform: Trailing garbage, "translate(40,undefined)".
Error: <text> attribute transform: Trailing garbage, "translate(600,NaN)".
@mbostock mbostock added the bug Something isn’t working label Sep 12, 2023
Fil added a commit that referenced this issue Sep 20, 2023
@Fil
fix autoHeight and outerRange for empty scale domains
5f2b448 
closes #1856
@Fil Fil linked a pull request Sep 20, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn’t working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix autoHeight and outerRange for empty scale domains observablehq/plot
1 participant
@mbostock