Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more stress tests and benchmarks #450

Open
Tracked by #388
talex5 opened this issue Feb 25, 2023 · 0 comments
Open
Tracked by #388

Add more stress tests and benchmarks #450

talex5 opened this issue Feb 25, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@talex5
Copy link
Collaborator

talex5 commented Feb 25, 2023

The only stress test we have is stress_semaphore.ml and the benchmarks mostly test the synchronisation primitives but not the OS integration (except for bench_fd.ml, which tests reading from /dev/zero). We need more.

In particular, we have found several resource leaks and races when e.g. spawning and joining domains in a tight loop (e.g. #421). The https://github.com/ocaml-multicore/retro-httpaf-bench/tree/master/cohttp-eio benchmark is useful; more like that (or simpler) would be good.

Testing for FD leaks would also be worth doing. e.g. checking that we have the same number of open FDs at the end of running the tests.

It would be very interesting to look at the benchmarks with e.g. https://magic-trace.org/ to see if there are obvious inefficiencies left.

The benchmarks could go in this repository (if simple) or we could create a new project just for that (if they have lots of dependencies).

Stress testing https://github.com/ocaml-multicore/lwt_eio would be useful too.

@talex5 talex5 added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 25, 2023
@talex5 talex5 mentioned this issue Feb 25, 2023
25 tasks
@balat balat added this to the Eio 1.0 milestone May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants