Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix entropy of random state #597

Closed
kayceesrk opened this issue Jun 26, 2021 · 1 comment
Closed

Fix entropy of random state #597

kayceesrk opened this issue Jun 26, 2021 · 1 comment
Labels
post 5.00 Items to be worked on after OCaml 5.0 release

Comments

@kayceesrk
Copy link
Contributor

Note: after thinking harder about this, I think that changing n < 12 to n < 11 is not the best way to do this change. (If we get exactly 11 bytes from /dev/urandom, we do want to add some non-random seeds; currently the after-PR implementation will lack a bit of entropy in this weird corner case that will probably not occur in practice.)

I proposed a refactoring of the upstream function in ocaml/ocaml#10472 that would have made it easier to correctly extend the function.

Originally posted by @gasche in #582 (comment)
@kayceesrk kayceesrk added the post 5.00 Items to be worked on after OCaml 5.0 release label Oct 27, 2021
@kayceesrk
Copy link
Contributor Author

Fixed by ocaml/ocaml#10742.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
post 5.00 Items to be worked on after OCaml 5.0 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kayceesrk