Rename ocamlopttoplevel.cmxa to ocamltoplevel.cmxa #10078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows from ocaml#10061 by renaming the library to further unify the two toplevels. Some remaining references to `Opttop*` have also been cleaned up.
mshinwell
approved these changes
Dec 15, 2020
dbuenzli
pushed a commit
to dbuenzli/ocaml
that referenced
this pull request
Mar 25, 2021
This follows from ocaml#10061 by renaming the library to further unify the two toplevels. Some remaining references to `Opttop*` have also been cleaned up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows from #10061 by renaming the library to further unify the two toplevels.
Some remaining references to
Opttop*have also been cleaned up.Note that no further patch to
ocamlfindshould be necessary as the includedMETAfile already declaredopttoplevel.cmxaas the native archive for the toplevel — https://github.com/ocaml/ocamlfind/blob/9e406208dfe60160fbdc1ea135d1cc0e2ef8e216/site-lib-src/compiler-libs/META.in#L37This might be an issue for linking the native toplevel with dune until it has dedicated support, but that will only affect the native toplevel, that doesn't seem to be used in the wild (as the lack of META definition points out...).