Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use PROFINFO_WIDTH if WITH_PROFINFO defined #10102

Merged
merged 1 commit into from Jan 1, 2021

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Dec 29, 2020

Small configuration hardening split off from #9284.

Copy link
Contributor

@xavierleroy xavierleroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clearer and more robust this way. The Changes message confused me, though.

Changes Outdated Show resolved Hide resolved
PROFINFO_WIDTH should be 0 if WITH_PROFINFO is not defined - this
ensures that it's never used in this case.
@xavierleroy xavierleroy merged commit aca8472 into ocaml:trunk Jan 1, 2021
dbuenzli pushed a commit to dbuenzli/ocaml that referenced this pull request Mar 25, 2021
PROFINFO_WIDTH should be 0 if WITH_PROFINFO is not defined.
This PR ensures that it's never used in this case.
@dra27 dra27 deleted the profinfo-width branch July 6, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants