Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual built with trunk lacks syntax colouring on examples #10163

Closed
johnwhitington opened this issue Jan 18, 2021 · 3 comments
Closed

Manual built with trunk lacks syntax colouring on examples #10163

johnwhitington opened this issue Jan 18, 2021 · 3 comments

Comments

@johnwhitington
Copy link
Contributor

See, for example, this image: https://coherentpdf.com/tmp/colours.png

On the left, manual built with trunk. On the right, the 4.11 manual as uploaded to caml.inria.fr.

Was this intentional? It looks like a downgrade to me....

@Octachron
Copy link
Member

This is an accident: when merging the api and manual side of the documentation generation, I forgot to pick the -colorize-code option. I would propose to fix that in #9997 to avoid overriding the fix here.

@johnwhitington
Copy link
Contributor Author

Ok, so does that mean it will be colorized correctly for the 4.12 release?

@Octachron
Copy link
Member

Yes, the change in the documentation generation that introduced the bug is only present in trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants