Factorise yet another small bit of the byte/native toplevels #10187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drup
approved these changes
Feb 4, 2021
|
Travis complains that you are missing a Changes entry (you could add this PR number to the previous factoring-the-toplevels change entry, if there is one), and that the dependencies are not up-to-date anymore, which you could fix with |
|
Indeed @gasche, updated; sorry for the lag. |
It's actually even simpler this way! Note that one small change in the interface was required: the function Toploop.eval_address could raise a `Symtable.Error` for undefined globals. Since that wouldn't make sense for the native toplevel, we define a specific exception for this purpose. Hopefully no one was relying on this at so low-level.
ghost
merged commit
garrigue
pushed a commit
to garrigue/ocaml
that referenced
this pull request
Mar 3, 2021
…0187) It's actually even simpler this way! Note that one small change in the interface was required: the function Toploop.eval_address could raise a `Symtable.Error` for undefined globals. Since that wouldn't make sense for the native toplevel, we define a specific exception for this purpose. Hopefully no one was relying on this at so low-level.
smuenzel
pushed a commit
to smuenzel/ocaml
that referenced
this pull request
Mar 30, 2021
…0187) It's actually even simpler this way! Note that one small change in the interface was required: the function Toploop.eval_address could raise a `Symtable.Error` for undefined globals. Since that wouldn't make sense for the native toplevel, we define a specific exception for this purpose. Hopefully no one was relying on this at so low-level.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's actually even simpler this way!
Note that one small change in the interface was required: the function
Toploop.eval_address could raise a
Symtable.Errorfor undefined globals. Sincethat wouldn't make sense for the native toplevel, we define a specific exception
for this purpose. Hopefully no one was relying on this at so low-level.