Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add {Int,Int32,Int64,Nativeint}.{min,max} #10391

Closed
wants to merge 7 commits into from
Closed

Add {Int,Int32,Int64,Nativeint}.{min,max} #10391

wants to merge 7 commits into from

Conversation

nojb
Copy link
Contributor

@nojb nojb commented May 4, 2021

Fixes #10389

  • The first commit adds the new functions
  • The second commit (optional) uses them in the rest of the stdlib

xavierleroy
xavierleroy reviewed May 4, 2021
View reviewed changes
Copy link
Contributor

@xavierleroy xavierleroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need @since annotations everywhere. Otherwise this looks good to me.

@nojb
Copy link
Contributor Author

nojb commented May 4, 2021

You need @since annotations everywhere. Otherwise this looks good to me.

Thanks, fixed.

@nojb nojb mentioned this pull request May 4, 2021
Merged
@nojb
Copy link
Contributor Author

nojb commented May 4, 2021 •
edited

Closing in favor of #10392 which has a greater scope (it adapts the compiler codebase as well).

@nojb nojb closed this May 4, 2021
@nojb nojb deleted the minmax branch October 10, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavierleroy xavierleroy xavierleroy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose {Int,Int32,Int64,Nativeint}.{min,max}
2 participants
@nojb @xavierleroy