Use hypot to implement Complex.norm #10786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris00
force-pushed
the
trunk
branch
2 times, most recently
from
017cd3a
to
f35b3a3
Compare
|
I do not think a change entry is needed for this. |
|
Unless we're absolutely certain that the float representation of every possible outcome is the same, I'd put it in a Changes entry... someone'll notice otherwise! 🙂 |
xavierleroy
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Well spotted! This is a nice improvement: even if we use the hypot emulation in runtime/floats.c, NaNs and infinities are handled better in Float.hypot than in the current code for Complex.norm. Plus, we reduce code size.
I agree with @dra27 that a Changes entry would be useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that OCaml is in feature freeze at the moment but I nonetheless submit this (trivial) PR before I forget!