Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Random to a splitting generator #10877

Closed
gasche opened this issue Jan 11, 2022 · 5 comments
Closed

Move Random to a splitting generator #10877

gasche opened this issue Jan 11, 2022 · 5 comments
Assignees
Milestone

Comments

@gasche
Copy link
Member

gasche commented Jan 11, 2022

(This is a tracking issue for Random+Multicore, which we could act upon now that Multicore is merged in trunk.)

There is consensus that Random should "split" its global generator state when a new domain is spawned. There are two aspects to this:

@gasche gasche added this to the 5.00.0 milestone Jan 11, 2022
@xavierleroy
Copy link
Contributor

Sir! Yes, sir! Right now I'm fixing a 2x slowdown in the bytecode interpreter (#10880) and trying to get the Inria CI working again, but after this I'll devote all my attention to the PRNG, sir!

@xavierleroy
Copy link
Contributor

In the meantime, why don't you resurrect ocaml-multicore/ocaml-multicore#756 as a pull request here? We'll need DLS keys of the "split from parent" kind anyway.

@gasche
Copy link
Member Author

gasche commented Jan 12, 2022

Indeed, this is the first item above and I'm planning to do this soon. (Unfortunately I don't have a 2x speedup of my own to report ;-)

@gasche
Copy link
Member Author

gasche commented Jan 12, 2022

I have submitted the Domain.DLS change as an upstream PR: #10887.

@xavierleroy
Copy link
Contributor

I think we're done with this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants